The purpose of this PR is to hopefully address rectorphp/rector#8179.

I have tried to add atomic commits which should hopefully explain the changes made if you have time to review them commit by commit. I first started by adding failing tests as part of the first commit, which when running when checked out on that commit, fail.

I then refactored the existing code slightly to reuse the existing logic but with a renamed variable name, and then made the changes which I hope are along the right lines and within the expectations of the contributing guide.

The new method getPhpDataProviderAttribute, I added, is very similar to the existing code of

I am also not sure if we have to add a check that the version of PHP should be at least 8.0 for this feature, I tried to do so but the existing configured rule logic caused my tests to fail when having the following check in the rule:

    private function getPhpDataProviderAttribute($node): ?Attribute
    {
+        if (!$this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::ATTRIBUTES)) {
+            return null;
+        }

because of the existing code:

I have left out the above isAtLeastPhpVersion check for now.

Other notes

• Please see the commit and test I added for allowing only single data providers per test method. We may want to add this for the PHPDoc style of declaring data providers too, but I thought it may be out of scope for this PR, to do so. I hope you can see why this may be undesirable, because the types across different providers may be different - unless we did some sort of merging of all providers to determine the type.
• I also added a rather minor housekeeping update for the docs to do with a missing ;, I can remove this if you would like it to be separate from this PR / want it gone.
• I am not sure if I was supposed to include the built docs as part of the PR, which I have done.

Technical notes

• As mentioned in the PHPUnit 10 upgrade: Support PHP 8 attributes for adding metadata to test classes and test methods as well as tested code units sebastianbergmann/phpunit#4502

PHPUnit 10 will first look for metadata in attributes before it looks at comments

which we probably want to do here.

• An edge case that I may not have covered is for test methods that do the following (although it would be very unlikely but I guess could happen like anything 😄 ):

    /** @dataProvider provideData */
    #[\PHPUnit\Framework\Attributes\DataProvider('provideMoreData')]
    public function testAttributes($one, $two): void
    {
    }

    public static function provideData(): Iterator
    {
        yield ['string', 456];
    }

    public static function provideMoreData(): Iterator
    {
        yield [456, 'string'];
    }

Should we account for this?

Please let me know if you would like to make any changes, or please feel free to make any modifications to suit your needs/code style, if preferred.

I am fairly new to writing code in Rector but it is a rather enjoyable thing to work with.